Skip to content

Conversation

@cehan-Chloe
Copy link
Contributor

@cehan-Chloe cehan-Chloe commented Dec 9, 2025

Define error controller types and hooks

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@cehan-Chloe cehan-Chloe marked this pull request as ready for review December 10, 2025 14:00
@cehan-Chloe cehan-Chloe requested a review from a team as a code owner December 10, 2025 14:00
@cehan-Chloe cehan-Chloe marked this pull request as draft December 11, 2025 15:53
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 93.45794% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.90%. Comparing base (12cdc54) to head (527683d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/player/src/controllers/error/controller.ts 90.00% 12 Missing ⚠️
core/player/src/controllers/error/middleware.ts 96.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
+ Coverage   85.83%   85.90%   +0.07%     
==========================================
  Files         505      509       +4     
  Lines       22794    23007     +213     
  Branches     2656     2678      +22     
==========================================
+ Hits        19565    19764     +199     
- Misses       2900     2914      +14     
  Partials      329      329              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Bundle Report

Changes will increase total bundle size by 156.56kB (2.79%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
plugins/async-node/core 468.87kB 13.25kB (2.91%) ⬆️
plugins/beacon/core 416.1kB 13.25kB (3.29%) ⬆️
core/player 988.76kB 35.35kB (3.71%) ⬆️
plugins/check-path/core 434.5kB 13.25kB (3.15%) ⬆️
plugins/common-expressions/core 420.36kB 13.25kB (3.26%) ⬆️
plugins/common-types/core 494.69kB 13.25kB (2.75%) ⬆️
plugins/markdown/core 675.18kB 13.25kB (2.0%) ⬆️
plugins/metrics/core 452.67kB 13.25kB (3.02%) ⬆️
plugins/stage-revert-data/core 398.12kB 15.18kB (3.97%) ⬆️
plugins/reference-assets/core 475.82kB 13.25kB (2.87%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: plugins/metrics/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MetricsPlugin.native.js 13.25kB 420.32kB 3.26%
view changes for bundle: plugins/beacon/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
BeaconPlugin.native.js 13.25kB 401.64kB 3.41%
view changes for bundle: plugins/reference-assets/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
ReferenceAssetsPlugin.native.js 13.25kB 445.92kB 3.06%
view changes for bundle: core/player

Assets Changed:

Asset Name Size Change Total Size Change (%)
Player.native.js 14.68kB 417.35kB 3.64%
cjs/index.cjs 7.02kB 194.87kB 3.74%
index.legacy-esm.js 6.83kB 188.27kB 3.76%
index.mjs 6.83kB 188.27kB 3.76%
view changes for bundle: plugins/markdown/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MarkdownPlugin.native.js 13.25kB 650.02kB 2.08%
view changes for bundle: plugins/stage-revert-data/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
StageRevertDataPlugin.native.js 13.25kB 391.3kB 3.51%
index.legacy-esm.js 1.93kB 1.93kB 100.0% ⚠️
view changes for bundle: plugins/common-expressions/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonExpressionsPlugin.native.js 13.25kB 399.12kB 3.43%
view changes for bundle: plugins/common-types/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonTypesPlugin.native.js 13.25kB 423.51kB 3.23%
view changes for bundle: plugins/async-node/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
AsyncNodePlugin.native.js 13.25kB 422.8kB 3.24%
view changes for bundle: plugins/check-path/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CheckPathPlugin.native.js 13.25kB 405.02kB 3.38%

@cehan-Chloe cehan-Chloe requested a review from KetanReddy January 8, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants