Skip to content

Conversation

@mrigankmg
Copy link
Contributor

Change Type (required)

Indicate the type of change your pull request is:

Expose resolveRequestTime hook in MetricsPlugin

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@mrigankmg
Copy link
Contributor Author

/canary

@mrigankmg mrigankmg force-pushed the expose-resolve-request-time-hook branch from 361f9ae to 6e47528 Compare May 27, 2025 17:26
@mrigankmg mrigankmg force-pushed the expose-resolve-request-time-hook branch from 6e47528 to 3e81db5 Compare May 27, 2025 17:30
}

player.start(simpleFlowString)
assertEquals(expectedRequestTime, actualRequestTime)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this at all flakey

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (26e3b8f) to head (38a5341).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         333      333           
  Lines       20606    20606           
  Branches     1992     1992           
=======================================
  Hits        18596    18596           
  Misses       1994     1994           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KetanReddy KetanReddy marked this pull request as draft July 25, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants