Skip to content

[FIX] Fix createFn being blocked by empty input validation #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willeastcott merged 1 commit into from
Jan 6, 2026
Merged

[FIX] Fix createFn being blocked by empty input validation #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/SelectInput/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,10 @@ class SelectInput extends Element implements IBindable, IFocusable {
// during change event
if (label.destroyed) return;
label.text = value;
// Hide the create label if the value is invalid (in invalidOptions, empty, or whitespace-only)
// Hide the create label if the value is invalid (in invalidOptions, empty, or whitespace-only).
// Skip the empty/whitespace check if there's a createFn, as it may handle empty values (e.g., show a dialog).
const invalid = (this.invalidOptions && this.invalidOptions.indexOf(value) !== -1) ||
!value || value.trim() === '';
(!this._createFn && (!value || value.trim() === ''));
if (invalid) {
if (!container.hidden) {
container.hidden = true;
Expand All @@ -415,8 +416,9 @@ class SelectInput extends Element implements IBindable, IFocusable {

const text = label.text;

// Validate that the value is not empty or whitespace-only
if (!text || text.trim() === '') {
// Validate that the value is not empty or whitespace-only.
// Skip this check if there's a createFn, as it may handle empty values (e.g., show a dialog).
if (!this._createFn && (!text || text.trim() === '')) {
return;
}

Expand Down