refactor: migrate What's New to control-strip and extract viewport SCSS#1763
Merged
refactor: migrate What's New to control-strip and extract viewport SCSS#1763
Conversation
Rewrite picker-release-notes.ts to use a PCUI Button inside a control-strip Container instead of a custom popup. Use a real span dismiss icon inside the button DOM since pseudo-elements cannot receive click events. Extract .viewport, .control-strip, .whoisonline, and .chat-widget styles from _editor-main.scss into a new _editor-viewport.scss partial. Delete _editor-release-notes.scss (absorbed into _editor-viewport.scss). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the "What's New" notification to use the established control-strip pattern and extracts viewport-related SCSS into a dedicated file for better organization.
Changes:
- Migrated "What's New" popup from a custom picker implementation to a proper PCUI Button within a control-strip Container, matching existing viewport toolbar patterns
- Extracted all viewport overlay styles (viewport, control-strip, whoisonline, chat-widget) from
_editor-main.scssinto a new dedicated_editor-viewport.scssfile - Replaced the GitHub icon reference from E191 (bake icon) to E259 (proper GitHub icon) for better semantic meaning
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/editor/toolbar/toolbar-whats-new.ts |
New implementation using control-strip pattern with proper PCUI Button and custom dismiss icon DOM element |
src/editor/pickers/picker-release-notes.ts |
Removed old custom picker implementation |
src/editor/index.ts |
Moved import from pickers section to toolbar section |
sass/editor/_editor-viewport.scss |
New file consolidating all viewport-related styles including new bottom-right control-strip positioning and whats-new button styles |
sass/editor/_editor-release-notes.scss |
Removed old standalone styles file |
sass/editor/_editor-main.scss |
Removed viewport overlay styles (moved to _editor-viewport.scss) |
sass/editor.scss |
Updated import to reference new viewport SCSS file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
kpal81xd
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<span>dismiss icon inside the button DOM (since pseudo-elements cannot receive their own click events), withstopPropagationto separate the dismiss click from the button click.viewport,.control-strip,.whoisonline,.chat-widget) from_editor-main.scssinto a new_editor-viewport.scsspartial_editor-release-notes.scss(absorbed into_editor-viewport.scss)Test plan