This repository was archived by the owner on Dec 18, 2025. It is now read-only.
Change sanitization rules for script names generation#110
Merged
willeastcott merged 1 commit intoplaycanvas:mainfrom Nov 11, 2025
Merged
Change sanitization rules for script names generation#110willeastcott merged 1 commit intoplaycanvas:mainfrom
willeastcott merged 1 commit intoplaycanvas:mainfrom
Conversation
willeastcott
approved these changes
Nov 11, 2025
|
Thanks! 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current sanitization rules lead to some weird results as discussed here: playcanvas/editor#1511
And is generally too strict, benefiting those who uses
file-name-dash-notation.jsfor naming files, but some users might useFileNamingLikeClasses.js, and current rules will change it too much, leading to some lower cases letters where unexpected and preventing capital letters in a row (although this is withing Googles Coding Standards which PlayCanvas relies on).Here is an example of current sanitization results:
And here after this PR:
Fixes playcanvas/editor#1511