This repository was archived by the owner on Dec 18, 2025. It is now read-only.
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ShareDB connection implementation by eliminating private methods in favor of inline callbacks and replacing the message queue with a promise-based locking mechanism. The changes consolidate ShareDB type registration from a separate module into the connection file and introduce a new Deferred utility class.
Key Changes:
- Replaced message queue (
_sendQueue) with promise-based locking (_sendPromise) using a newDeferredclass - Inlined private event handler methods (
_onConnect,_onError, etc.) directly into event listener callbacks - Moved ShareDB type registration from
sharedb.tsintoconnection.ts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/sharedb.ts | Removed standalone ShareDB configuration module |
| src/realtime/connection.ts | Refactored connection handling with inline callbacks and promise-based message sending |
| src/deferred.ts | Added new utility class for creating deferred promises |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
slimbuck
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes