Skip to content

Adding feature to return current waypoint index#11

Open
christomaszewski wants to merge 6 commits intomasterfrom
feature/get_waypoints_index
Open

Adding feature to return current waypoint index#11
christomaszewski wants to merge 6 commits intomasterfrom
feature/get_waypoints_index

Conversation

@christomaszewski
Copy link
Member

Needs testing.

@christomaszewski christomaszewski requested a review from psigen April 26, 2017 15:03
@jjblum
Copy link
Contributor

jjblum commented Apr 26, 2017

Okay, so if you build with dependencies in netbeans, it passes all the tests. If you don't, it fails a test or two. I did test this in the field with the core lib jar built with dependenices and it functions as intended. So i'm not sure how to classify it. The "NOT FUNCTIONAL" commit message isn't correct, at least. I tried to update the commit message, but my git-fu was too weak.

…o be compiled with dependencies to pass the tests.
@jjblum
Copy link
Contributor

jjblum commented May 10, 2017

Why would my update cause this test to fail:

/**
 * Test of isConnected method, of class UdpVehicleServer.
 */
@Test
public void testIsConnected() {
    UdpVehicleServer instance = new UdpVehicleServer(serviceAddress);
    VehicleServer server = AsyncVehicleServer.Util.toSync(instance);

    // Since we are using a test server, it should always be connected
    assertTrue("Server claimed it was not connected", server.isConnected());
}

@psigen
Copy link
Member

psigen commented May 11, 2017

It might be a race condition in the test code networking that just makes it fail at random. We can rerun the test and if it passes, it should be good.

@shantanu-vyas shantanu-vyas self-requested a review June 13, 2017 20:21
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the file now, the indent is not right after your fix either.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the damn indents

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments