Adding feature to return current waypoint index#11
Open
christomaszewski wants to merge 6 commits intomasterfrom
Open
Adding feature to return current waypoint index#11christomaszewski wants to merge 6 commits intomasterfrom
christomaszewski wants to merge 6 commits intomasterfrom
Conversation
Contributor
|
Okay, so if you build with dependencies in netbeans, it passes all the tests. If you don't, it fails a test or two. I did test this in the field with the core lib jar built with dependenices and it functions as intended. So i'm not sure how to classify it. The "NOT FUNCTIONAL" commit message isn't correct, at least. I tried to update the commit message, but my git-fu was too weak. |
…o be compiled with dependencies to pass the tests.
Contributor
|
Why would my update cause this test to fail: |
Member
|
It might be a race condition in the test code networking that just makes it fail at random. We can rerun the test and if it passes, it should be good. |
Contributor
There was a problem hiding this comment.
looking at the file now, the indent is not right after your fix either.
Member
Author
There was a problem hiding this comment.
fix the damn indents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs testing.