Use uv and pre-commit to run checks locally, and on GitHub Actions#19
Merged
danmilon merged 11 commits intoplatformsh:masterfrom Apr 30, 2025
Merged
Use uv and pre-commit to run checks locally, and on GitHub Actions#19danmilon merged 11 commits intoplatformsh:masterfrom
danmilon merged 11 commits intoplatformsh:masterfrom
Conversation
These versions are already at EOL.
This is produced by setuptools during editable installs.
This is a library package, which doesn't need a lock file for packaging purposes, but it's still useful for reproducible execution of development and testing tools, both locally and in CI.
This change adds basedpyright as a dev dependency, configures a pre-commit hook for it, and writes a baseline file to ignore all existing warnings, so they can be fixed incrementally.
This replaces the existing ruff check workflow with one that reuses the pre-commit configuration, checking everything included there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses pre-commit and uv together to enable running ruff, pyproject-fmt, prospector, basedpyright, py.test, and pre-commit-hooks. This allows the same configuration to be reused to run checks both locally, and on GitHub Actions. Tool installation is handled by uv, where possible, so the same tools can be conveniently run manually, and tool versions aren't duplicated between the project's dev dependencies and the pre-commit configuration.