Skip to content

update selections for boolean false #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincepsh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update selections for boolean false #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0443657
update selections for boolean false
Nov 24, 2021
40d6d6d
Implementing false_choices like colander.Boolean
Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion colander_tools/strict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,13 @@ class Boolean(SchemaType):
On deserialize, accepts a boolean or a boolean represented as a string.
"""

def __init__(
self,
false_choices=('false', '0', 'disabled', 'untrue'),
):

self.false_choices = false_choices

def serialize(self, node, appstruct): # noqa
if appstruct is null:
return null
Expand All @@ -86,7 +93,7 @@ def deserialize(self, node, cstruct):
raise Invalid(node, _('${val} is not a boolean', mapping={'val': cstruct}))
result = result.lower()

if result in ('false', '0'):
if result in self.false_choices:
return False

return True
Expand Down