Fix/pfc 414/handle app 2 app samsung get intent#36
Conversation
…ing unused method and hardcoding tokenReferenceId
…gle and Samsung wallet apps
Summary of ChangesHello @neijrbuilders, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial enhancement to the App2App simulation capabilities within both the Google Wallet and Samsung Wallet mock applications. It transitions the simulation process from relying on static or programmatically generated data to accepting dynamic user input for the 'Token Reference ID'. This modification empowers users with greater control over the simulation parameters, thereby facilitating more comprehensive and flexible testing of App2App integration flows. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
Este pull request melhora os aplicativos de mock do Google Wallet e Samsung Wallet, substituindo o dado simulado fixo por um campo de texto editável. Isso aumenta a flexibilidade para testes, permitindo a inserção de dados customizados em tempo de execução. As alterações são consistentes em ambos os aplicativos. A revisão inclui uma sugestão para extrair o valor padrão para uma constante, visando melhorar a manutenibilidade do código.
google-wallet-app-mock/app/src/main/java/com/google/android/gms_mock/MainActivity.kt
Outdated
Show resolved
Hide resolved
samsung-wallet-app-mock/app/src/main/java/com/samsung/android/spay_mock/MainActivity.kt
Outdated
Show resolved
Hide resolved
…ivity for Google and Samsung wallet apps
Task Jira
https://digitaldesk.pernambucanas.com.br/browse/PFC-414
Descrição
Screenshot nova tela alterada
Descrição
A necessidade de permitir que desenvolvedores testem diferentes valores de Token Reference ID durante o desenvolvimento e testes, ao invés de ter um valor fixo hardcoded. Isso facilita a validação de diferentes cenários de ativação de tokens nas wallets.
Não. As alterações são apenas nos apps mock de desenvolvimento/teste (Samsung Wallet Mock e Google Wallet Mock) e não afetam o código de produção.
Compilar e executar os apps mock:
cd samsung-wallet-app-mock && ./gradlew installDebugcd google-wallet-app-mock && ./gradlew installDebugAbrir o app mock no dispositivo/emulador
Verificar que o campo de input está visível com valor padrão preenchido
Testar edição do campo:
Testar simulação:
Equipe de desenvolvimento - melhoria de UX para facilitar testes durante desenvolvimento.
Tipo de alteração
Checklist: