refact(eks): update modulo version 19.20.0 to 21.15.1#47
refact(eks): update modulo version 19.20.0 to 21.15.1#47pb-kaio-santos wants to merge 1 commit intomainfrom
Conversation
60cb698 to
e07e3f3
Compare
Summary of ChangesHello @pb-kaio-santos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant upgrade of the AWS EKS Terraform module to its latest major version. This update necessitated extensive refactoring of module inputs and variable definitions to ensure compatibility and leverage the new functionalities. The changes aim to keep the EKS infrastructure definitions current and robust, while also providing a new example for Terragrunt users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively upgrades the EKS Terraform module from v19.20.0 to v21.15.1. The changes correctly handle the breaking changes from the module upgrade, such as variable renames and a more flexible approach to configuring addons and security group rules. This refactoring improves the module's maintainability and usability. I've also noticed that explicit types have been added to many variables, which is a great improvement for code quality. My review includes a couple of minor suggestions to correct invalid Kubernetes versions used in an example file and a variable description to avoid confusion.
Upgrade EKS module to v21.0
This upgrade introduced multiple drifts and variable renames.
All drifts were resolved and deprecated variables were updated accordingly.
For detailed upgrade notes:
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/UPGRADE-21.0.md