Skip to content

Conversation

@sanya-pf9
Copy link
Contributor

@sanya-pf9 sanya-pf9 commented Dec 22, 2025

Summary

Implements the foundational storage SDK layer for array-based migration support. This PR establishes the core infrastructure for integrating storage arrays (Pure Storage) with VJailbreak's migration workflow.

Changes

  • Added storage SDK with Pure Storage provider implementation
  • Created ArrayCreds CRD for storage array credentials management
  • Implemented storage layer in vpwned-sdk with protobuf definitions
  • Added vCenter helper functions for storage array discovery
  • Generated gRPC service definitions for storage operations
  • Updated go modules across pkg/vpwned, k8s/migration, and v2v-helper

Technical Details

New CRDs

  • ArrayCreds: Manages storage array credentials and connection details

New Services

  • StorageArrayServer: gRPC service for storage array operations
  • storage/pure/pure.go: Pure Storage FlashArray integration

Key Files

  • pkg/vpwned/sdk/proto/v1/api.proto: Storage API definitions
  • k8s/migration/api/v1alpha1/arraycreds_types.go: ArrayCreds CRD
  • k8s/migration/internal/controller/arraycreds_controller.go: Controller logic
  • pkg/vpwned/server/storage.go: Storage gRPC server implementation

fixes #1091
fixes #1093

Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@sanya-pf9 sanya-pf9 changed the title Feature/storage sdk foundation pr1 Implement Storage SDK Foundation (#1091 #1093) - PART1 Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create gRPC API for Storage Operations Implement Storage SDK Foundation

3 participants