Feature branch for array integration. #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

spai-p9 wants to merge 86 commits into main from feature/array-integration

Collaborator

spai-p9 commented Nov 18, 2025 •

edited

Loading

What this PR does / why we need it

Which issue(s) this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)

fixes #

Special notes for your reviewer

Testing done

please add testing details (logs, screenshots, etc.)

spai-p9 and others added 25 commits

November 7, 2025 00:42


          make cr changes, implement storage layer in vpwned-sdk

95827c7


          update go mod

0d85d36


          generate protocol buffer files

1f3f428


          go mod tidy v2v-helper

eccaa52


          add array creds controller

557fb97


          fix ResolveCinderVolumeToLUN function

8e3365a


          add later

d4b99bc


          add vcenter helper functions

e18680e


          fix datastores func

f52c6f9


          feat: Adding types.go for esx-ssh package

15401b0

Can change the location


          feat: Client represents an SSH client connected to an ESXi host

b6d9ba0


          feat: ESXiOperations defines the interface for ESXi operations via SSH

8973f8c


          feat: Dumping all additional supporting functions to utils.go

7c410e6


          feat: The main core logic of esxi-ssh setup and progress tracker

2fe593c


          chore: test file to test esxi ssh

14fe61d


          chore: adding go.mod for esxi-ssh package

da7eed6


          fix: Address code review comments from Windsurf bot

db44091

- Fix error handling in parseSize function
  - Fix potential infinite loop in StreamDisk with labeled break
  - Fix goroutine leaks in ExecuteCommandWithProgress


          fix: Reducing the context of this PR to just ESXI SSH connection and …

ebf84ba

…VM/datastore discovery


          fix: Fixing the 0GB DataStore and +1 Datastore count

631ba26


          fix: addressing some windsurf comments

3d56452


          fix: making test connection context aware

049ff5d


          fix: mod tidy

66fe026


          chore: remove cached references of esxi-ssh

a701150


          Add CR's to support array based copy, storage creds to handle storage…

230b0f2

… related ops, Auto detect arrays on target env so that discovery is easy for the user, Create UI to trigger the flow and understand the basic flow.


          Merge feature/array-ui into feature/array-integration

ecb5047

- Integrated ArrayCreds UI management components
- Added ArrayCredsMapping CRD for vendor-based storage migration
- Merged storage SDK enhancements (Pure Storage support)
- Combined auto-discovery features from both branches
- Resolved conflicts in CRDs, controllers, and go.mod files

Contributor

windsurf-bot bot commented Nov 18, 2025

This PR has too many files to review (>50 files).

huly-for-github bot commented Nov 18, 2025

Connected to Huly®: VJAIL-950

Contributor

bito-code-review bot commented Nov 18, 2025

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.


          Merge branch 'main' into feature/array-integration

bc7feb8

Signed-off-by: K Suhas Pai <suhas@platform9.com>

Contributor

bito-code-review bot commented Nov 18, 2025

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

spai-p9 and others added 17 commits

December 8, 2025 13:54


          remove extra naa and improve the rescan logic

b5a73ff


          fix warning

303be11


          fix string matching

e6949f7


          use vmdk path correctly

511ee2e


          fix cinder manage command

63d989c


          move mapping volume before cinder manage

793a619


          do cinder manage, then group the volume to host and then copy

753ec4e


          add log and change the rdm path to the datastore

73b2c76


          add robust wait logic after triggering the clone


          fix: Add VM power state check before VAAI copy to prevent file lock e…

5b0371d

…rrors


          fix: Adding waits for potential race conditions

My guess is there is a race condition after we rescan, esxi needs time
to fully initialize the device after it appears, but we start the
process as soon as the path is created. This is befor the VAAI XCOPY


          fix: removing the poweroff check, assuming the VM should alreday be p…

7392a5b

…owered off


          fix: Not relying on the PID to sync the clone tracker

8626f63

learning: ESXI is extremely slow, we need to make these calls
asynchronous


          increase the initial probing for the process to 5mins

ab42e81


          change ps command to detect the process to kill this works

b751540


          add logging for every 5percent incrememnt of clone copy

cef7608


          Simplify clone status monitor logic

60edeaa

Contributor

bito-code-review bot commented Dec 8, 2025

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

spai-p9 added 4 commits

December 8, 2025 16:04


          Merge branch 'main' into feature/array-integration

4951bb0

Signed-off-by: K Suhas Pai <suhas@platform9.com>


          update dependencies

ed29f1b


          fix build issues

87ac4a6


          Fix UI build

11e85c8

Contributor

bito-code-review bot commented Dec 8, 2025

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

1 similar comment

Contributor

bito-code-review bot commented Dec 9, 2025

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

sanya-pf9 force-pushed the feature/array-integration branch from 05b5693 to 11e85c8 Compare

December 9, 2025 02:01

Contributor

bito-code-review bot commented Dec 9, 2025

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

spai-p9 added 3 commits

December 12, 2025 18:07


          Add proper phases and logging. (#1265)

463fc30


          Merge branch 'main' into feature/array-integration

35ecec4

Signed-off-by: K Suhas Pai <suhas@platform9.com>


          fix build issues

7e9847d

Contributor

bito-code-review bot commented Dec 12, 2025

Bito Automatic Review Skipped - Large PR

Bito didn't auto-review this change because the pull request exceeded the line limit. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet