JBRes-???? Support Java in Function Modification Stage #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../main/kotlin/org/plan/research/minimization/plugin/services/MinimizationPsiManagerService.kt
Fixed
Show fixed
Hide fixed
InversionSpaces
force-pushed
the
feat/support-java
branch
4 times, most recently
from
666741f to
32c7a38
Compare
...rc/main/kotlin/org/plan/research/minimization/plugin/modification/psi/PsiBodyTypeRenderer.kt
Show resolved
Hide resolved
InversionSpaces
force-pushed
the
feat/support-java
branch
from
186359d to
28c1c0a
Compare
...in/src/main/kotlin/org/plan/research/minimization/plugin/modification/psi/PsiBodyReplacer.kt
Fixed
Show fixed
Hide fixed
InversionSpaces
changed the title
SBOne-Kenobi
approved these changes
Mar 12, 2025
Collaborator
SBOne-Kenobi
left a comment
SBOne-Kenobi
left a comment
There was a problem hiding this comment.
LGTM, but it needs testing on some project
Collaborator
Author
|
Checked by adding a java file to one of the test projects. It did work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JBRes-???? Support Java methods and lambda expressions modification in function modification stage
Description
Support body replacement with
throw new UnsupportedOperationException("Removed by DD");for Java methods and lambda expressions. For this, PSI collection was updated to include Java source files andPsiBodyReplacerwas updated to support corresponding Java PSI elements.How to test
Automated tests
project-minimization-plugin/src/test/kotlin/psi/manager/MinimizationPsiManagerGettingJavaTest.ktandproject-minimization-plugin/src/test/kotlin/lens/FunctionModificationLensTest.ktSelf-check list
Hint: [x] is a marked item