Draft
Conversation
Collaborator
SBOne-Kenobi
left a comment
SBOne-Kenobi
left a comment
There was a problem hiding this comment.
LGTM, it's needed to fix tests only
project-minimization-plugin/src/test/kotlin/snapshot/ProjectCloningSnapshotTest.kt
Outdated
Show resolved
Hide resolved
project-minimization-plugin/src/test/kotlin/snapshot/ProjectCloningSnapshotTest.kt
Outdated
Show resolved
Hide resolved
SBOne-Kenobi
previously approved these changes
Jan 29, 2025
SBOne-Kenobi
dismissed
their stale review
Need to check libs + delete excluding of tests
… sbone/snapshot-refactoring
…ces with Intellij IDEA
...src/main/kotlin/org/plan/research/minimization/plugin/services/LocalHistoryWrapperService.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/plan/research/minimization/plugin/services/LocalHistoryWrapperService.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/plan/research/minimization/plugin/services/LocalHistoryWrapperService.kt
Outdated
Show resolved
Hide resolved
project-minimization-plugin/src/main/resources/META-INF/plugin.xml
Outdated
Show resolved
Hide resolved
# Conflicts: # docs/SnapshotManagers.md # project-minimization-plugin/src/main/kotlin/org/plan/research/minimization/plugin/Util.kt # project-minimization-plugin/src/main/kotlin/org/plan/research/minimization/plugin/context/snapshot/impl/ProjectLocalHistorySnapshotManager.kt # project-minimization-plugin/src/main/kotlin/org/plan/research/minimization/plugin/model/state/SnapshotStrategy.kt # project-minimization-plugin/src/main/kotlin/org/plan/research/minimization/plugin/services/MinimizationStageExecutorService.kt # project-minimization-plugin/src/test/kotlin/snapshot/ProjectCloningSnapshotTest.kt
SBOne-Kenobi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git snapshot
This PR implements classes
GitWrapperServiceandProjectGitSnapshotManagerwhich are responsible for Git and its usage for snapshots.This PR actually is an inheritance of older PR JBRes-1796 Git Snapshot Impl which was adapted for new snapshot logic after refactors.
How to test
Automated tests
see
GitWrapperTestandProjectGitSnapshotManagerTestManual tests
You can test it manually by setting Snapshot strategy as
PROJECT_GIT.Self-check list
Hint: [x] is a marked item