You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Low-risk text-only change to an LLM prompt. Main risk is inconsistency and duplication in instructions that can confuse the model or break snapshot/tests.
Findings:
[Severity: Medium] llm/llm.go:~311 — Inconsistent/duplicated prompt sections
Explanation: The change updates the first occurrence of “Output format should be in Markdown...” to “Format your response in markdown...” and adds “It should have these sections:”. A second occurrence of the old phrasing remains later in the prompt. The prompt appears to include “What to do” and “Output format…” blocks twice. Conflicting/duplicated instructions can degrade LLM adherence, increase token usage, and may break any snapshot tests that assert the full prompt content.
Suggestion: Make both occurrences consistent or deduplicate so the instructions appear once. If duplication is intentional (e.g., composing prompts), ensure both use the same updated phrasing.
Quick patch (synchronize the second occurrence):
Replace the later “Output format should be in Markdown syntax and have these sections:” with:
“Format your response in Markdown, with code examples where relevant using appropriate syntax highlighting.
It should have these sections:”
Alternatively, remove the duplicated earlier block if it’s truly redundant.
[Severity: Low] llm/llm.go:~311 — Minor style inconsistency and potential downstream formatting impact
Explanation: The new text requests code examples with syntax highlighting, which may encourage fenced code blocks. If any downstream renderer/parsers are sensitive to fences or heavy formatting, this could cause issues. Also “markdown” vs “Markdown” casing differs between occurrences.
Suggestion: Confirm consumers handle fenced code blocks. Use consistent casing (“Markdown”) across the prompt.
[Severity: Low] Tests/snapshots — Potential snapshot/string match failures
Explanation: If you have tests that snapshot the prompt string or assert specific substrings (e.g., “Output format should be…”), they may fail.
Suggestion: Update snapshots and assertions to the new wording; add a test to ensure there’s only one copy of each instruction block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.