Skip to content

fix: escape html/markdown in titles #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SKalt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: escape html/markdown in titles #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion markdown_writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (w MarkdownWriter) WriteSummary(content string, newLine bool) string {

func (w MarkdownWriter) WriteHeader(feed *gofeed.Feed) string {
favicon := w.getFaviconHTML(feed)
return fmt.Sprintf("\n### %s %s\n", favicon, feed.Title)
return fmt.Sprintf("\n### %s %s\n", favicon, escapeMd(feed.Title))
}

// Helper method specifically for MarkdownWriter
Expand All @@ -105,3 +105,23 @@ func (w MarkdownWriter) getFaviconHTML(s *gofeed.Feed) string {

return fmt.Sprintf(`<img src="%s" width="32" height="32" />`, src)
}

func escapeMd(raw string) (safe string) {
out := strings.Builder{}
out.Grow(len(raw))
i := 0
for i < len(raw) {
b := raw[i] // we're only escaping ascii characters, so iterating over bytes is fine
switch b {
case '\\', '<', '>', '[', ']':
if err := out.WriteByte('\\'); err != nil {
panic(err)
}
}
if err := out.WriteByte(b); err != nil {
panic(err)
}
}

return out.String()
}