Skip to content

Add FEC to SDP parsing #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoTurk merged 2 commits into from
Feb 8, 2026
Merged

Add FEC to SDP parsing #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b0065a
Add FEC to SDP parsing
Feb 2, 2026
1a3a691
Remove irrelevant data
Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions unmarshal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,6 +895,7 @@ func unmarshalMediaDescription(lex *lexer) (stateFn, error) { //nolint:cyclop
"UDT",
"IX",
"MRCPv2",
"FEC",
) {
return nil, fmt.Errorf("%w `%v`", errSDPInvalidNumericValue, field)
}
Expand Down
9 changes: 9 additions & 0 deletions unmarshal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,11 @@ const (
MediaTCPTLSMRCPv2 = TimingSDP +
"m=application 1544 TCP/TLS/MRCPv2 1\r\n"

MediaFECSDP = TimingSDP +
"m=application 50178 UDP/FEC *\r\n" +
"a=fec-repair-flow:encoding-id=8; fssi=E:1234,S:0,m:7\r\n" +
"a=repair-window:500ms\r\n"

CanonicalUnmarshalSDP = "v=0\r\n" +
"o=jdoe 2890844526 2890842807 IN IP4 10.47.16.5\r\n" +
"s=SDP Seminar\r\n" +
Expand Down Expand Up @@ -333,6 +338,10 @@ func TestRoundTrip(t *testing.T) {
Name: "MediaTCPTLSMRCPv2",
SDP: MediaTCPTLSMRCPv2,
},
{
Name: "MediaFEC",
SDP: MediaFECSDP,
},
} {
test := test
t.Run(test.Name, func(t *testing.T) {
Expand Down
Loading