Improve test coverage for unmarshal #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
===========================================
+ Coverage 82.78% 97.54% +14.75%
===========================================
Files 12 12
Lines 1685 1385 -300
===========================================
- Hits 1395 1351 -44
+ Misses 221 18 -203
+ Partials 69 16 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philipch07
force-pushed
the
pch07/improve-test-coverage-oct-25-pt-2
branch
8 times, most recently
from
f1fc496 to
985f6d3
Compare
philipch07
force-pushed
the
pch07/improve-test-coverage-oct-25-pt-2
branch
from
985f6d3 to
31c82c7
Compare
JoTurk
approved these changes
Oct 24, 2025
Member
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
wow the coverage is too good now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing to improve test coverage. Unmarshal has the least coverage compared to the other files by far and is the last main file that needs coverage.
Reference issue
Related to #193