Skip to content

Comments

Fix logger creation in SenderInterceptorFactory#400

Merged
mengelbart merged 1 commit intopion:masterfrom
sirzooro:fix_logger_creation
Feb 4, 2026
Merged

Fix logger creation in SenderInterceptorFactory#400
mengelbart merged 1 commit intopion:masterfrom
sirzooro:fix_logger_creation

Conversation

@sirzooro
Copy link
Contributor

@sirzooro sirzooro commented Feb 4, 2026

Default one was always set so provided loggerFactory was not used.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.82%. Comparing base (048be58) to head (1750164).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   79.78%   79.82%   +0.04%     
==========================================
  Files          88       88              
  Lines        4581     4581              
==========================================
+ Hits         3655     3657       +2     
+ Misses        741      740       -1     
+ Partials      185      184       -1     
Flag Coverage Δ
go 79.82% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sirzooro sirzooro requested a review from JoTurk February 4, 2026 07:18
Default one was always set so provided loggerFactory was not used.
@mengelbart mengelbart merged commit 35588b3 into pion:master Feb 4, 2026
18 checks passed
@sirzooro sirzooro deleted the fix_logger_creation branch February 4, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants