Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
=============================================
+ Coverage 0 100.00% +100.00%
=============================================
Files 0 1 +1
Lines 0 31 +31
=============================================
+ Hits 0 31 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7ac7cd5 to
286e427
Compare
JoTurk
approved these changes
Feb 20, 2026
Member
JoTurk
left a comment
There was a problem hiding this comment.
Thank you, and sorry for missing track of this change.
Contributor
Author
|
No worries, I realize it is hard to review a huge change, such as #2, at once. This will hopefully make it easier to follow, and having more people looking at this and understanding the reasoning is much better. Thanks for the fast review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the loss-based component of the refactored congestion controller. The relevant section from the internet-draft is here: https://datatracker.ietf.org/doc/html/draft-ietf-rmcat-gcc-02#section-6