fix(rtc-sender): downgrade track processing error logs to debug level#130
Open
hanguyen-nuro wants to merge 1 commit intomasterfrom
Open
fix(rtc-sender): downgrade track processing error logs to debug level#130hanguyen-nuro wants to merge 1 commit intomasterfrom
hanguyen-nuro wants to merge 1 commit intomasterfrom
Conversation
Change all track processing error logs from Error to Debug level in processEncodedFrames to prevent syslog overload. These errors (including ErrNoFrameAvailable and others) occur frequently during normal operation and are not actionable at Error level.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 33.33% 33.33%
=======================================
Files 18 18
Lines 1545 1545
=======================================
Hits 515 515
Misses 984 984
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
approved these changes
Feb 10, 2026
Comment on lines
-514
to
518
| // ErrNoFrameAvailable is expected during normal operation (timing gaps between frames) | ||
| // Log it at Debug level to reduce noise; other errors remain at Error level | ||
| // Log all track processing errors at Debug level to avoid overloading syslog | ||
| if errors.Is(result.error, ErrNoFrameAvailable) { | ||
| s.log.Debugf("No frame available for track %s", result.trackID) | ||
| } else { |
Contributor
There was a problem hiding this comment.
Do you think we should just have one line like:
s.log.Debugf("Error processing track %s: %v", result.trackID, result.error)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change all track processing error logs from Error to Debug level in processEncodedFrames to prevent syslog overload. These errors (including ErrNoFrameAvailable and others) occur frequently during normal operation and are not actionable at Error level.