Open
Conversation
Change require versión of composer.json
Update README.md
The class constant wasn't defined but seems are defined in the GetId3\GetId3Core class.
Fix in BaseHandler::saceAttachment.
Replaced many direct property calls to get/set instead. Updated README.md to get the last version in deps installation. Updated tests to use new setters.
Wrong namespace, replaced with Mp3 (already imported in header)
Fix crash on Mp3 class call line 1491
Fatal error: Call to private method GetId3\GetId3Core::warning() from context 'GetId3\Handler\BaseHandler' in /vagrant/vendor/phansys/getid3/GetId3/Handler/BaseHandler.php on line 215
Fix fatal private method error
Update Mpeg.php
Did also do some minor fixes to follow the .travis.yml convention.
Added PHP 5.6, 5.5 and HHVM to travis.yml
…(phansys) This PR was merged into the 2.1 branch. Discussion ---------- Commits ------- 665024c Allow PHP 7, add missing definitions at `composer.json`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are you going to update this to 1.9.7?
thank you :)