Skip to content

Conversation

@Grecil
Copy link

@Grecil Grecil commented Jun 25, 2024

Problem

Everytime an object of this class is initialise, the model is downloaded again. This wastes time, memory and network resources

Solution

Added optional input "model_dir" to specify the directory model should be downloaded in and loaded from.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

Grecil added 3 commits June 25, 2024 12:11
…hould be downloaded in or loaded from.

This saves a lot of time, memory and network resources.
@Grecil
Copy link
Author

Grecil commented Jun 25, 2024

image
Takes only 0.8 seconds to load now. Earlier it used to take atleast 100 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant