Open
Conversation
fix _write_sentence for pyhton3 fix send_command for pyhton3 add missung elements from nmea sentences add initialisation of PA1010D add waitforfix
This reverts commit 76c47e1.
Member
|
The missing NMEA sentences are handy, thank you, but I have a few concerns;
This level of exception handling is a bit heavy-handed for the underlying library. If you need to catch exceptions in read/write that could be done in the client app. Generally:
If you'd be happy to strip out all the exception handling for now and make this a clean PR just adding the missing NMEA sentences, we can go from there with some kind of logging example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix _write_sentence for pyhton3
fix send_command for pyhton3
add missing elements from nmea sentences
add initialisation of PA1010D
add waitforfix