-
Notifications
You must be signed in to change notification settings - Fork 12
Fix/Mobile-UI-Fix-WalletConnectButton #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying x with
|
| Latest commit: |
634559b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c64731d0.x-e62.pages.dev |
| Branch Preview URL: | https://fix-mobile-ui-fix.x-e62.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/apps/pillarx-app/components/WalletConnectDropdown/WalletConnectDropdown.tsx (1)
366-366: Remove redundant padding declarations.The class list contains both
py-[9px] px-3andp-4. Sincep-4appears later in the list, it overrides the earlier padding values, makingpy-[9px] px-3redundant.Apply this diff to remove the redundant padding:
- <div className="flex flex-col py-[9px] px-3 w-[254px] h-fit border-x-2 border-t-2 border-b-4 rounded-[10px] border-[#121116] gap-4 absolute left-0 p-4 bg-container_grey z-10"> + <div className="flex flex-col w-[254px] h-fit border-x-2 border-t-2 border-b-4 rounded-[10px] border-[#121116] gap-4 absolute left-0 p-4 bg-container_grey z-10">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/apps/pillarx-app/components/WalletConnectDropdown/WalletConnectDropdown.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: lint
- GitHub Check: unit-tests
🔇 Additional comments (3)
src/apps/pillarx-app/components/WalletConnectDropdown/WalletConnectDropdown.tsx (3)
337-341: Verify the height mismatch is intentional.The wrapper has
h-12(48px) while the inner button hash-[44px](44px), creating a 4px height difference. If this vertical spacing is intentional for visual alignment, consider adding a brief comment. Otherwise, these values should match.
366-366: Verify fixed dropdown width works on small mobile screens.The dropdown now uses a fixed width of
w-[254px]. On very small mobile viewports (< 254px), this could cause horizontal overflow or clipping. Since this is marked as a mobile UI fix, please confirm that the 254px fixed width has been tested on the smallest target screen sizes.
337-366: Solid approach to the button sizing refactor.The changes successfully implement the PR objective: the button wrapper and trigger now use
w-fitfor dynamic width based on content, while the dropdown panel uses a fixedw-[254px]width. This approach provides visual consistency for the dropdown while allowing the button to adapt to its content.
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Summary by CodeRabbit