Skip to content

[NotReady] Invert zero state for null fields. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kevpie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[NotReady] Invert zero state for null fields. #52

kevpie wants to merge 1 commit into from

Conversation

@kevpie
Copy link
Contributor

@kevpie kevpie commented Apr 22, 2016

Closes #51

@eduohe
Copy link
Contributor

eduohe commented Apr 25, 2016

Looks good!

abrykajlo
abrykajlo reviewed Apr 25, 2016
View reviewed changes
field/time_date.go
if v.IsZero() {
nt.Valid = false
nt.validNull = true
nt.invalidNull = true
Copy link
Contributor

@abrykajlo abrykajlo Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this bool not being flipped because of invalidity?

Copy link
Contributor Author

@kevpie kevpie Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in this location! 👍

@kevpie kevpie changed the title Invert zero state for null fields. [WIP] Invert zero state for null fields. May 19, 2016
@kevpie kevpie changed the title [WIP] Invert zero state for null fields. [NotReady] Invert zero state for null fields. May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevpie @eduohe @abrykajlo