Skip to content

Conversation

@devrajbando
Copy link

πŸ“˜ Pull Request Template – PhysicsHub

Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.


πŸ” Description

Fixed the UI of the Select Box for the Dark Mode:


βœ… Checklist

Before requesting a review, please ensure that you have:

  • Verified that the project builds and runs locally (npm run dev)
  • Ensured no ESLint or TypeScript warnings/errors remain
  • Updated documentation, comments, or in-code explanations where needed
  • Verified responsiveness across devices (desktop, tablet, mobile)
  • Followed the CONTRIBUTING.md guidelines

🎨 Visual Changes (if UI-related)

Before Change:
Screenshot 2026-01-28 192241

After Change:
Screenshot 2026-01-28 192257


πŸ“‚ Type of Change

  • πŸ› Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to change)
  • πŸ“ Documentation update
  • ♻️ Refactor / code quality improvement
  • 🎨 UI/UX enhancement
  • πŸ”’ Security improvement

🧩 Additional Notes for Reviewers

border-color: var(--accent-color);
background: var(--bg-color);
box-shadow: 0 4px 12px rgba(0, 230, 230, 0.3);
transform: translateY(-2px);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transform is nice, but it causes a bug where if you hover on the bottom of the button, where it rises 2px, the hover enters an infinite loop, which isn't nice.

If you want to keep the hover, fix this bug; otherwise, you can remove it.

padding: 8px 12px;
border: 2px solid var(--accent-color);
border-radius: 8px;
background: var(--bg-color);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
background: var(--bg-color);
background: var(--bg-light);

Change of default background due to the following suggestion

text-transform: uppercase;
box-shadow: 0 2px 8px rgba(0, 0, 0, 0.15);
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[data-theme="light"] .callout-type-selector {
background: var(--bg-color);
}

because I don't really like the black bg on dark mode

@physicshub
Copy link
Owner

Hey thank you for the PR, I decided to merge yours, but you first need to fix some things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unclear select Box for callouts when creating a Blog

2 participants