-
-
Notifications
You must be signed in to change notification settings - Fork 36
Fixed UI of Select Box in callout in Blog Editor #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| border-color: var(--accent-color); | ||
| background: var(--bg-color); | ||
| box-shadow: 0 4px 12px rgba(0, 230, 230, 0.3); | ||
| transform: translateY(-2px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transform is nice, but it causes a bug where if you hover on the bottom of the button, where it rises 2px, the hover enters an infinite loop, which isn't nice.
If you want to keep the hover, fix this bug; otherwise, you can remove it.
| padding: 8px 12px; | ||
| border: 2px solid var(--accent-color); | ||
| border-radius: 8px; | ||
| background: var(--bg-color); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| background: var(--bg-color); | |
| background: var(--bg-light); |
Change of default background due to the following suggestion
| text-transform: uppercase; | ||
| box-shadow: 0 2px 8px rgba(0, 0, 0, 0.15); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [data-theme="light"] .callout-type-selector { | |
| background: var(--bg-color); | |
| } | |
because I don't really like the black bg on dark mode
|
Hey thank you for the PR, I decided to merge yours, but you first need to fix some things |
π Pull Request Template β PhysicsHub
Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.
π Description
Fixed the UI of the Select Box for the Dark Mode:
Closes [Bug]: Unclear select Box for callouts when creating a BlogΒ #167
β Checklist
Before requesting a review, please ensure that you have:
npm run dev)π¨ Visual Changes (if UI-related)
Before Change:

After Change:

π Type of Change
π§© Additional Notes for Reviewers