Skip to content

Fix dig spot crash on native hardware/melonDS #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mike8699 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix dig spot crash on native hardware/melonDS #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tests/desmume/test_dig_spot_items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
start_first_file,
use_equipped_item,
)
from .melonds import MelonDSWrapper


@pytest.fixture
Expand All @@ -28,8 +27,6 @@ def dig_spot_test_emu(
aux_data: ShufflerAuxData,
):
"""Generate and run a rom with a custom dig/shovel spot item set."""
if isinstance(emulator, MelonDSWrapper):
pytest.skip('This test is broken on melonDS. TODO: Fix it and remove this skip')
rom = NintendoDSRom.fromFile(rom_path)
chests = [
chest
Expand Down
Loading