Skip to content

Optimize C code to decrease size of compiled binaries #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mike8699 merged 1 commit into from
Apr 10, 2022
Merged

Optimize C code to decrease size of compiled binaries #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/src/set_initial_flags.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "flags.h"
#include <stdint.h>

void set_flag(int addr, uint8_t bit) {
__attribute__((always_inline)) static void set_flag(int addr, uint8_t bit) {
*((uint8_t *)addr) |= bit;
}

Expand Down
16 changes: 7 additions & 9 deletions base/src/spawn_custom_freestanding_item.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,6 @@

#define RUPY 0x52555059

static uint16_t get_item_id() {
uint16_t *item_id_address;
// pull the base address of the NPCA entry's item_id off of the stack
asm volatile("ldr %0, [sp, #0x4]" : "=r"(item_id_address) :);
// return the item id
return item_id_address[0x10];
}

/**
* @param param_1 - original function arg, don't modify
* @param npc_type - 4 character string representing NPC type.
Expand All @@ -22,7 +14,13 @@ uint16_t spawn_custom_freestanding_item(void *param_1, uint32_t npc_type,
uint16_t (*spawn_npc)(void *, uint32_t, void *, uint16_t *) =
(void *)0x20C3FE8;

uint16_t item_id = get_item_id();
uint16_t *item_id_address;
// pull the base address of the NPCA entry's item_id off of the stack
asm volatile("ldr %0, [sp, #0x4]" : "=r"(item_id_address) :);

// get the item id
uint16_t item_id = item_id_address[0x10];

// if item_id is 0x1, continue as the vanilla game does.
if (item_id == 0x1) {
return (*spawn_npc)(param_1, npc_type, param_3, param_4);
Expand Down