Skip to content

Conversation

@jablan
Copy link
Collaborator

@jablan jablan commented Dec 9, 2025

https://github.com/urllib3/urllib3/blob/main/CHANGES.rst#260-2025-12-05 introduces a breaking change which causes errors with the client (presumably getheaders removal). Pinning the version to 2.5 until we adapt the library.

@jablan jablan requested a review from Copilot December 9, 2025 07:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR pins the urllib3 dependency to versions below 2.6 to address compatibility issues. The change ensures that all Python OpenAPI generator templates consistently specify an upper bound for the urllib3 version requirement.

  • Adds an upper bound constraint (<2.6) to urllib3 dependency specifications
  • Updates both standard and experimental Python templates
  • Ensures consistency across setup files, requirements files, and documentation

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
openapi-generator/templates/python/setup.mustache Adds upper bound to urllib3 version in REQUIRES list
openapi-generator/templates/python/requirements.mustache Adds upper bound to urllib3 version in requirements
openapi-generator/templates/python/python-experimental/setup.mustache Adds upper bound to urllib3 version in experimental setup
openapi-generator/templates/python/python-experimental/requirements.mustache Adds upper bound to urllib3 version in experimental requirements
openapi-generator/templates/python/python-experimental/README_onlypackage.mustache Updates documentation to reflect urllib3 version constraint
openapi-generator/templates/python/README_onlypackage.mustache Updates documentation to reflect urllib3 version constraint

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jablan jablan requested a review from theSoenke December 9, 2025 07:56
@jablan jablan merged commit 04177c5 into main Dec 9, 2025
12 checks passed
@jablan jablan deleted the scd-642-python-pin-urllib3 branch December 9, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants