Skip to content

Conversation

@lookasc
Copy link
Contributor

@lookasc lookasc commented Nov 11, 2025

Changed the workflow in .github/workflows/developer-hub.yml to let the phrase/developer-hub repository mention and assign the author of the original merged PR.

Relates to:
https://github.com/phrase/developer-hub/pull/99

@lookasc lookasc marked this pull request as ready for review November 11, 2025 10:33
@lookasc lookasc requested review from docstun and jablan November 11, 2025 10:41
Copy link
Collaborator

@jablan jablan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Does the resulting PR in developer hub need to be manually approved/merged?

@lookasc
Copy link
Contributor Author

lookasc commented Nov 11, 2025

Interesting! Does the resulting PR in developer hub need to be manually approved/merged?

@jablan Yes, resulting PR will still need to be manually approved and merged. The difference is that the user will be notified and assigned to the resulting PR, so we'll (hopefully) avoid plenty of forgotten PRs.
Please have a look here as well.

@jablan
Copy link
Collaborator

jablan commented Nov 11, 2025

@lookasc is there a way to automate that? there's no reason (other than a technical one) not to merge it without developer interaction.

@lookasc lookasc merged commit 0312fe3 into main Nov 11, 2025
13 checks passed
@lookasc lookasc deleted the chore/dev-hub branch November 11, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants