Pulling in changes from upstream #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2021 10:10
The original development was done at git://kernel.ubuntu.com/jk/sbsigntool.git and that's what phrack forked 9 years ago. There's a new maintainer, and the current fork resides at: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/sbsigntools.git/ The new, official repo does add OpenSSL engine support, however it does not seem to work with the fake keys that are used by CloudHSM (and likely other HSMs as well). The phrack fork works just fine with those fake keys. I went through the changes manually and here are the changes that stuck out to me: - openssl 1.1 compatibility - checking return codes - adding ability to add multiple certificates - fixing a Y2K bug - multiple levels of verbosity - more test scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to get autoconf.sh to run, so I found the new upstream repo and pulled in the changes from there. After that, autoconf.sh worked just fine. I also updated the README.md because that had me really confused for several hours before I found that it wasn't the latest upstream code.