Skip to content

Conversation

@DavidePastore
Copy link
Member

No description provided.

@DavidePastore DavidePastore added the enhancement New feature or request label Feb 19, 2025
@DavidePastore
Copy link
Member Author

Hi @alfsb. Could you please take a look into this? Do you think it's the right order for the commands to be executed? Also, if tomorrow the build is broken, are we going to still get the results of the next commands?

@alfsb
Copy link
Member

alfsb commented Feb 19, 2025

Hi @alfsb. Could you please take a look into this? Do you think it's the right order for the commands to be executed?

Yes. This is a good order. Yet, as these commands only generates output, one suggestion it to put broken.php and all qaxml-* runs in one "Checks" step, so all quality warnings will not be spread in 3 separate clicks.

Also, if tomorrow the build is broken, are we going to still get the results of the next commands?

These scripts do not EXIT_FAILURE, so they will not interrupt CI runs. You want to CI fail/stop in case of output?

@DavidePastore
Copy link
Member Author

Thanks for confirming, @alfsb.

These scripts do not EXIT_FAILURE, so they will not interrupt CI runs. You want to CI fail/stop in case of output?

No, this is not necessary at this point.

@DavidePastore DavidePastore merged commit 446f6a3 into master Mar 24, 2025
1 check passed
@DavidePastore DavidePastore deleted the feature/add-more-commands-in-ci branch March 24, 2025 14:43
@alfsb
Copy link
Member

alfsb commented Sep 1, 2025

The line php doc-base/scripts/broken.php it is now included on configure.php, so the CI will duplicate the warnings.

@DavidePastore
Copy link
Member Author

@alfsb, fixed in #83

ManueldG pushed a commit to ManueldG/doc-it that referenced this pull request Oct 8, 2025
* Add more commands to check build status

* Split into steps

* Fix command

* Add folder argument

* Re-arrange steps

* Remove --depth for doc-en

* Use one single step to execute all the checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants