Skip to content

Conversation

@nexxome
Copy link
Contributor

@nexxome nexxome commented Nov 27, 2025

Since Symfony 7.4 properties in Validator Metadata classes are private, so we have to use getters here.

@bocharsky-bw
Copy link
Member

Thanks! Could you take a look at the PhpStan failed build, please?

@nexxome
Copy link
Contributor Author

nexxome commented Dec 1, 2025

hmm, I don't really understand why phpstan is failing. The error is "Call to an undefined method PhpParser\ParserFactory::createForVersion().", but nikic/php-parser 5.6 is used. I also can't reproduce it.

2025-11-29T09:22:25.2604321Z Note: Using configuration file /github/workspace/phpstan.neon.dist.
2025-11-29T09:22:27.9513126Z ##[error]Call to an undefined method PhpParser\ParserFactory::createForVersion().
2025-11-29T09:22:27.9576274Z ------ ----------------------------------------------
2025-11-29T09:22:27.9579244Z Line FileExtractor/PHPFileExtractor.php
2025-11-29T09:22:27.9579992Z ------ ----------------------------------------------
2025-11-29T09:22:27.9580522Z 36 Call to an undefined method
2025-11-29T09:22:27.9584985Z PhpParser\ParserFactory::createForVersion().
2025-11-29T09:22:27.9585510Z ------ ----------------------------------------------
2025-11-29T09:22:27.9586010Z
2025-11-29T09:22:27.9586288Z
2025-11-29T09:22:27.9586566Z [ERROR] Found 1 error

@bocharsky-bw
Copy link
Member

OK, the PHPStan error seems unrelated to these changes, let's merge it

If you want to give it a try to fix PHPStan error in another PR - it's warmly welcome!

Thank you!

@bocharsky-bw bocharsky-bw merged commit 68054ca into php-translation:master Dec 2, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants