Skip xsi:type generation for anonymous complex types. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR prevents the generation of xsi:type attributes for anonymous complex types in SOAP XML encoding. Anonymous complex types don't have accessible names, so including xsi:type attributes for them is unnecessary since they can be mapped directly from their declaration or through their children's types.
- Added logic to skip
xsi:typegeneration when a type is marked as local/anonymous - Updated test expectations to reflect the removal of
xsi:typeattribute for anonymous complex types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Xml/Writer/XsiAttributeBuilder.php | Added check to skip xsi:type generation for local/anonymous complex types |
| tests/PhpCompatibility/Schema036Test.php | Updated test expectation to remove xsi:type attribute from anonymous testType2 element |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
veewee
force-pushed
the
skip-xsi-type-for-anonymous-complex-types
branch
from
ae2fee6 to
d06203b
Compare
veewee
force-pushed
the
skip-xsi-type-for-anonymous-complex-types
branch
from
d06203b to
176548d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Works together with the change in:
php-soap/wsdl-reader#52
anonymous complex-types won't get any
xsi:typeattribute since they can be mapped directly from either the declaration (literal) or since the children's types are known (for encoded).