[FrankenPHP] Add minimum memory threshold for worker restarts #191
+51
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `frankenphp_min_memory_mb` option to enforce a minimum memory threshold before handling new requests. This prevents running workers when memory is critically low, enhancing stability. Option is configurable via environment variables or runtime options. Default value is -1 which disables this new functionality.
Author
|
@Nyholm For our project this would be really helpful. What do you think about this? |
Nyholm
reviewed
Dec 27, 2025
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Thank you. Great idea. But I made some minor comments
|
|
||
| private function hasAvailableMemory(int $loops): bool | ||
| { | ||
| if (-1 === $this->minMemoryMb || 1 === $loops) { // Always allow the first cycle |
Member
There was a problem hiding this comment.
If 1 === $loops, then we have completed the first request. If we are out of memory after the first request, we should restart, right?
I suggest removing this check.
| if (strlen($memoryLimit) < 2) { | ||
| return true; // Unexpected value, consider enough mem available | ||
| } | ||
| $last = \strtolower($memoryLimit[\strlen($memoryLimit) - 1]); |
Member
There was a problem hiding this comment.
Note that a valid ini settings is:
memory_limit=4711
This menas 4711 bytes. See https://www.php.net/manual/en/ini.core.php#ini.memory-limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
frankenphp_min_memory_mboption to define minimum available memory (in MB) required before handling a new requestfrankenphp_loop_max)FRANKENPHP_MIN_MEMORY_MBenvironment variable-1(disabled)How to test
FRANKENPHP_MIN_MEMORY_MB=64and verify worker restarts when available memory drops below 64MB