Skip to content

mark - Fix about AndroidX and Fix file download failed #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
90Mark wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mark - Fix about AndroidX and Fix file download failed #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/java/com/philipphecht/FileProviderClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.philipphecht;

public class FileProviderClass extends android.support.v4.content.FileProvider {
public class FileProviderClass extends androidx.core.content.FileProvider {
}
7 changes: 3 additions & 4 deletions android/src/main/java/com/philipphecht/RNDocViewerModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.views.webview.ReactWebViewManager;

/* bridge react native
int size();
Expand All @@ -31,7 +30,7 @@
import java.io.InputStream;
import java.net.HttpURLConnection;
import java.net.URL;
import android.support.v4.content.FileProvider;
import androidx.core.content.FileProvider;

import android.content.ActivityNotFoundException;
import android.content.Context;
Expand Down Expand Up @@ -250,11 +249,11 @@ private File downloadFile(String url, String fileName, Boolean cache, String fil

return f;
} catch (Exception err) {
err.printStackTrace();
callback.invoke(ERROR_FILE_NOT_FOUND);
err.printStackTrace();
} finally {
conn.disconnect();
}

return null;
}

Expand Down