Skip to content

fix errors for react-native 0.62+ #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maulikdhameliya wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix errors for react-native 0.62+ #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d75521d
fix errors for react-native 0.62+
maulikdhameliya May 8, 2020
b22d0d7
fix android release build issue
maulikdhameliya May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,17 @@ buildscript {

apply plugin: 'com.android.library'

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
compileSdkVersion 25
buildToolsVersion "25.0.0"
compileSdkVersion safeExtGet('compileSdkVersion', 28)
buildToolsVersion safeExtGet('buildToolsVersion', '28.0.3')

defaultConfig {
minSdkVersion 16
targetSdkVersion 26
versionCode 1
versionName "1.0"
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 28)
}
lintOptions {
abortOnError false
Expand Down
4 changes: 1 addition & 3 deletions android/src/main/java/com/philipphecht/RNDocViewerModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.views.webview.ReactWebViewManager;

/* bridge react native
int size();
Expand All @@ -31,7 +30,7 @@
import java.io.InputStream;
import java.net.HttpURLConnection;
import java.net.URL;
import android.support.v4.content.FileProvider;
import androidx.core.content.FileProvider;

import android.content.ActivityNotFoundException;
import android.content.Context;
Expand All @@ -42,7 +41,6 @@
import android.webkit.MimeTypeMap;
import android.widget.Toast;
import android.util.Log;
import android.webkit.WebView;

public class RNDocViewerModule extends ReactContextBaseJavaModule {
public static final int ERROR_NO_HANDLER_FOR_DATA_TYPE = 53;
Expand Down