Remove unused import ReactWebViewManager#133
Open
axemclion wants to merge 1 commit intophilipphecht:masterfrom
axemclion:patch-1
Open
Remove unused import ReactWebViewManager#133axemclion wants to merge 1 commit intophilipphecht:masterfrom axemclion:patch-1
axemclion wants to merge 1 commit intophilipphecht:masterfrom
axemclion:patch-1
Conversation
WebViewManager has been moved out of React Native, and looks like it is also unused. So removing the import. This is needed for moving React Native apps to 0.60 and depend on this package.
|
@axemclion , do you have a working fork for me to use this until its merged? |
Author
|
@zivchen - I dont. The change is trivial, can you create a repo, so that everyone else can also use it ? |
|
Hi axemclion. can you create a repo, everyone else can also use it ? |
wangwcq
pushed a commit
to wangwcq/react-native-doc-viewer
that referenced
this pull request
Oct 23, 2019
Prevent build failure. Reference: philipphecht#133
|
Im facing same issue. When this will go live? |
|
I just created my own repo. |
viniciusfont
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebViewManager has been moved out of React Native, and looks like it is also unused. So removing the import. This is needed for moving React Native apps to 0.60 and depend on this package.