Update ci.yml #97
Open
Update ci.yml #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flightsupport
suggested changes
Jan 15, 2026
flightsupport
left a comment
flightsupport
left a comment
There was a problem hiding this comment.
Hope we can get this released soon together with #96
| if [ "$?" != 0 ]; then | ||
| echo "Expected PHP version ${{ matrix.php-version}} failed to switch." | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
This block runs with set -xe
Therefore it exits anyway for a non-zero exit code.
Could be rewritten as:
./phpswitch.sh ${{ matrix.php-version }} -s || { echo "switch failed"; exit 1; }
Also, the code fails (exit 1) Why use exit 0 here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing PHP versions.