Make ced native module optional to prevent Windows startup crash#12
Merged
peterjthomson merged 6 commits intomasterfrom Jan 26, 2026
Merged
Make ced native module optional to prevent Windows startup crash#12peterjthomson merged 6 commits intomasterfrom
peterjthomson merged 6 commits intomasterfrom
Conversation
Co-authored-by: peterjthomson <9357736+peterjthomson@users.noreply.github.com>
Co-authored-by: peterjthomson <9357736+peterjthomson@users.noreply.github.com>
This reverts commit 7ea0f51.
Copilot
AI
changed the title
[WIP] Fix software not opening on Windows 10
Make ced native module optional to prevent Windows startup crash
Jan 26, 2026
Owner
|
@cursor review |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Remove trailing spaces on blank lines to pass ESLint.
Includes Windows startup crash fix (ced module made optional)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows app crashes on startup when the
cednative module fails to load due to architecture mismatch or build issues.Changes
encoding.jsPromise<Encoding>awaitinmarkdown.jswhereguessEncodingis calledImpact
App starts successfully even when ced module is unavailable. Encoding detection still works when the module loads correctly. Users with broken ced builds can now use the app with UTF-8 as default encoding.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.