Add under review passthru controllers from upstream ros_controllers#41
Closed
Add under review passthru controllers from upstream ros_controllers#41
Conversation
| { | ||
| try | ||
| { | ||
| joints_.push_back(hw->getHandle(joint_names_[i])); |
There was a problem hiding this comment.
To protect against users calling init twice, perhaps clear joints_ before adding the joints to it?
(And/or add an is_initialized bool that is set to true at the end of this function and is checked at the beginning of this function?)
amalnanavati
requested changes
Aug 19, 2021
amalnanavati
left a comment
There was a problem hiding this comment.
With the exception of the change in init (which imo should have been in the original ROS code as well), this looks good.
FYI, I effectively reviewed the upstream commit to ros-controllers as opposed to this one, to better capture the diff.
Contributor
Author
|
Closing. Superseded by personalrobotics/pr_ros_controllers#26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While waiting on a review of ros-controls/ros_controllers#569
This creates the following controllers:
With only the
joint_namesargument.Allows for either a subscriber float array connection-less interface (via the
commandtopic) or a JointGroupCommandAction (from pr_control_msgs, see personalrobotics/pr_control_msgs#3)