Open
Conversation
…o perception/chisel
…ains helper function for performing transformations on detected objects.
…cs/prpy into perception/chisel
… to tf for offscreen render to use
src/prpy/perception/chisel.py
Outdated
| import rospy | ||
|
|
||
| try: | ||
| rospy.init_node('chisel_detector',anonymous=True) |
Member
There was a problem hiding this comment.
We shouldn't call init_node here because it may only be called once per process. I prefer calling init_node only once, in the top-level script, to prevent this from happening twice.
src/prpy/perception/chisel.py
Outdated
| # Remove any previous bodies in the camera | ||
| for b in self.camera_bodies: | ||
| self.camera.remove_body(b) | ||
| self.camera_bodies = [] |
Member
There was a problem hiding this comment.
Why are these on self? It seems like a local variable would suffice.
Contributor
There was a problem hiding this comment.
camera_bodies? It is the list of bodies that the camera has added since being started, and needs to have state between calls to DetectObject
Member
Member
|
I've been starting to do this for our retimers/smoothers. See: |
…cs/prpy into perception/chisel
Contributor
Conflicts: src/prpy/perception/chisel.py src/prpy/perception/kinbody_helper.py
…r to account for detection noise during masking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we are ready to merge this. @Shushman and I checked that chisel is working. And I have verified simtrack also works with these changes. We should test vncc one more time to ensure I didn't introduce any bugs with by switching to use the
kinbody_helperfunctions. But in the meantime, lets start gathering comments on this PR and working it through.