It's possible for OPENPOSE_LOG4CXX to exist but be 0.

[travers-rhodes]

See defn of OPENPOSE_LOG4CXX at https://github.com/rdiankov/openrave/blob/b2818fb534cd8c4e64ea1dddea0f7c360ce5056d/CMakeLists.txt#L740 and usage at https://github.com/rdiankov/openrave/blob/master/include/openrave/logging.h

Maybe the machine has to be in a kinda weird setup in order to have OPENPOSE_LOG4CXX set to 0, but I think it's more correct to check if rather than ifdef here in order to see whether log4cxx should be used.

[travers-rhodes]

Oh, and for context, this was my error message when trying to build (which is fixed by this change):

Errors << or_ompl:make /home/travers/harp_ws/logs/or_ompl/build.make.002.log
/home/travers/harp_ws/src/or_ompl/src/OMPLConversions.cpp: In member function ‘virtual void or_ompl::OpenRAVEHandler::log(const string&, ompl::msg::LogLevel, const char*, int)’:
/home/travers/harp_ws/src/or_ompl/src/OMPLConversions.cpp:76:9: error: ‘log4cxx’ has not been declared
log4cxx::spi::LocationInfo const location_info(
^
/home/travers/harp_ws/src/or_ompl/src/OMPLConversions.cpp:76:36: error: expected ‘;’ before ‘const’
log4cxx::spi::LocationInfo const location_info(
^
/home/travers/harp_ws/src/or_ompl/src/OMPLConversions.cpp:79:13: error: ‘RaveGetLogger’ is not a member of ‘OpenRAVE’
OpenRAVE::RaveGetLogger(), location_info, text);
^
/home/travers/harp_ws/src/or_ompl/src/OMPLConversions.cpp:79:40: error: ‘location_info’ was not declared in this scope
OpenRAVE::RaveGetLogger(), location_info, text);
^
make[2]: *** [CMakeFiles/or_ompl.dir/src/OMPLConversions.cpp.o] Error 1
make[1]: *** [CMakeFiles/or_ompl.dir/all] Error 2
make: *** [all] Error 2
cd /home/travers/harp_ws/build/or_ompl; catkin build --get-env or_ompl | catkin env -si /usr/bin/make --jobserver-fds=6,7 -j; cd -