[FEATURE] Table Add data link to the table panel #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahrokni
force-pushed
the
feat/table_data_link
branch
2 times, most recently
from
2737172 to
02ce7e4
Compare
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com> Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
Gladorme
reviewed
Nov 27, 2025
Member
Gladorme
left a comment
Gladorme
left a comment
There was a problem hiding this comment.
I did not check in depth, but here is already some points that could improve the PR
| open: boolean; | ||
| setOpen: (value: boolean) => void; | ||
| }; | ||
| const LinkManagementDialogue = (props: LinkManagementDialogueProps): ReactElement => { |
Member
There was a problem hiding this comment.
Rename + move to dedicated file
Suggested change
| const LinkManagementDialogue = (props: LinkManagementDialogueProps): ReactElement => { | |
| const LinkManagementDialog = (props: LinkManagementDialogueProps): ReactElement => { |
| }; | ||
|
|
||
| return ( | ||
| <Dialog |
Contributor
Author
There was a problem hiding this comment.
It is Perses
The last item.
import {
AlignSelector,
FormatControls,
OptionsEditorColumn,
OptionsEditorControl,
OptionsEditorGrid,
OptionsEditorGroup,
SortSelectorButtons,
Dialog,
} from '@perses-dev/components';
Member
There was a problem hiding this comment.
Ok, I'm crazy I though I saw it in MUI import 😓
| <DialogTitle>{actionTitle}</DialogTitle> | ||
| <DialogContent> | ||
| <Stack spacing={2}> | ||
| <FormControl> |
Member
There was a problem hiding this comment.
We already have a form for editing links LinksEditor/LinkControl, can it be re-used (UI consistency and code re-usage)?
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
shahrokni
force-pushed
the
feat/table_data_link
branch
from
02ce7e4 to
4883b7c
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to perses/perses#3483
Description 🖊️
This PR adds Links and Actions setting section into the column settings.
Using this feature users will be able to generate dynamic links for each column of the table plugin.
The dynamic part of the URL is taken from the Cell Value.
As @AntoineThebaud explains in the issue A link should ...
Dynamic Link Settings 🔧 🔗
In settings users can define a link which includes three properties. URL, Title, and Open_New_Tab option.
The settings could be added, edited, and removed.
Test 🧪
You should be able to save/edit/remove link settings from column settings.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes