PermitContext - Removed unnecessary null check and Corrected spelling

[aniket414]

Changes:

1. Renamed permittedEnviroment to permittedEnvironment (Spelling Fix)
2. Removed unnecessary null check from verifyCanAccessProject and verifyCanAccessEnvironment. The equals() method already takes care of null check. Made the two methods above similar to verifyCanAccessOrg

[Copilot]

Pull request overview

This PR fixes a spelling error in a variable name and simplifies null check logic in verification methods. The changes rename permittedEnviroment to the correctly spelled permittedEnvironment throughout the codebase, and remove redundant null checks from access verification methods by relying on the equals() method's null-safe behavior.

• Corrected spelling of permittedEnviroment to permittedEnvironment across all occurrences
• Removed unnecessary null checks from verifyCanAccessProject and verifyCanAccessEnvironment methods

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This change introduces a potential NullPointerException if project is null. The original code checked permittedProject != null first, which was actually protecting against null values in permittedProject. However, if project (the parameter) is null, calling project.equals() will throw NPE. Consider using Objects.equals(project, permittedProject) or adding a null check for the project parameter.

[Copilot]

This change introduces a potential NullPointerException if environment is null. The original code checked permittedEnviroment != null first, which was protecting against null values. If environment (the parameter) is null, calling environment.equals() will throw NPE. Consider using Objects.equals(environment, permittedEnvironment) or adding a null check for the environment parameter.

[zeevmoney]

Hi @aniket414, thank you for the PR, I know it has been a long time, sorry for that, see my comments + the bot comments.

[zeevmoney]

Critical Bug: This change breaks the SDK for organization-level API keys.

The original null check is intentional business logic, not just null-safety:

• When permittedProject == null, it means the API key has org-level access and can access any project
• The original permittedProject != null && ... check allows null to pass through (no error thrown)

With this change:

• project.equals(null) returns false
• This causes an exception to be thrown, blocking org-level API keys from accessing any project

Note: verifyCanAccessOrg does not have a null check because permittedOrganization is never null in valid code paths (see saveApiKeyAccessibleScope - org is always set from the API key). In contrast, permittedProject can legitimately be null for org-level keys.

Please revert this change while keeping the spelling fix.

[zeevmoney]

Same issue here: This breaks project-level API keys trying to access environments.

When permittedEnvironment == null, the API key has project-level access and can access any environment within that project. The null check must be preserved.

Suggested fix: Keep the spelling correction (permittedEnvironment) but restore the null check:

if (permittedEnvironment != null && !environment.equals(permittedEnvironment)) {