Fix build galera with std::shared_ptr #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default scons configuration provides '-ansi' flag to g++ compiler, which actually means '-std=c++98'. So, later tests for c++11 features always fails and build finaly is always based on TR1/Boost implementations. Rewriting this flag to '-std=c++11' effectively invokes std library instead, but galera then fails to build because of using `for_each` without explicitly included <algorithm> (it seems that boost shared_ptr replacement uses it for own purposes, and pollutes global scope).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default scons configuration provides '-ansi' flag to g++ compiler, which
actually means '-std=c++98'. So, later tests for c++11 features always
fails and build finaly is always based on TR1/Boost implementations.
Rewriting this flag to '-std=c++11' effectively invokes std library
instead, but galera then fails to build because of using
for_eachwithout explicitly included (it seems that boost shared_ptr
replacement uses it for own purposes, and pollutes global scope).