Skip to content

Conversation

@percebus
Copy link
Owner

@percebus percebus commented Oct 5, 2025

Turns out that some JSDate.WtF tests fail in FireFox (cuz of course it does!)

@github-actions
Copy link

github-actions bot commented Oct 5, 2025

Test Results Deltas

  1 files  ±0   24 suites  ±0   2s ⏱️ ±0s
294 tests ±0  277 ✅ ±0  17 💤 ±0  0 ❌ ±0 
300 runs  ±0  283 ✅ ±0  17 💤 ±0  0 ❌ ±0 

Results for commit de1a828. ± Comparison against base commit 658beeb.

This pull request removes 23 and adds 23 tests. Note that renamed tests count towards both.
Date new Date("12.-1") does NOT equal "2001-01-01T00:00:00.000Z" ‑ Date new Date("12.-1") does NOT equal "2001-01-01T00:00:00.000Z"
Date new Date("12.-1") does NOT equal "2012-01-01T00:00:00.000Z" ‑ Date new Date("12.-1") does NOT equal "2012-01-01T00:00:00.000Z"
Date new Date("12.-1") ignores the "-", interpreting it like "12.1", resulting in "2001-12-01T00:00:00.000" ‑ Date new Date("12.-1") ignores the "-", interpreting it like "12.1", resulting in "2001-12-01T00:00:00.000"
Date new Date("12.1") does NOT equal "2001-01-01T00:00:00.000Z" ‑ Date new Date("12.1") does NOT equal "2001-01-01T00:00:00.000Z"
Date new Date("12.1") does NOT equal "2012-01-01T00:00:00.000Z" ‑ Date new Date("12.1") does NOT equal "2012-01-01T00:00:00.000Z"
Date new Date("12.1") equals "2001-12-01T00:00:00.000" ‑ Date new Date("12.1") equals "2001-12-01T00:00:00.000"
Date new Date("May 4 UTC") does NOT equal "2010-04-30T23:00:00.000Z" ‑ Date new Date("May 4 UTC") does NOT equal "2010-04-30T23:00:00.000Z"
Date new Date("May 4 UTC") does NOT equal "2010-05-01T00:00:00.000Z" ‑ Date new Date("May 4 UTC") does NOT equal "2010-05-01T00:00:00.000Z"
Date new Date("May 4 UTC") parses UTC as "2001-05-04T00:00:00.000Z" ‑ Date new Date("May 4 UTC") parses UTC as "2001-05-04T00:00:00.000Z"
Date new Date("May 4 UTC+1") does NOT equal "2001-05-04T00:00:00.000Z" ‑ Date new Date("May 4 UTC+1") does NOT equal "2001-05-04T00:00:00.000Z"
…
Date new Date("12.-1") .toISOString() does NOT equal "2001-01-01T00:00:00.000Z" ‑ Date new Date("12.-1") .toISOString() does NOT equal "2001-01-01T00:00:00.000Z"
Date new Date("12.-1") .toISOString() does NOT equal "2012-01-01T00:00:00.000Z" ‑ Date new Date("12.-1") .toISOString() does NOT equal "2012-01-01T00:00:00.000Z"
Date new Date("12.-1") .toISOString() ignores the "-", interpreting it like "12.1", resulting in "2001-12-01T00:00:00.000" ‑ Date new Date("12.-1") .toISOString() ignores the "-", interpreting it like "12.1", resulting in "2001-12-01T00:00:00.000"
Date new Date("12.1") .toISOString() does NOT equal "2001-01-01T00:00:00.000Z" ‑ Date new Date("12.1") .toISOString() does NOT equal "2001-01-01T00:00:00.000Z"
Date new Date("12.1") .toISOString() does NOT equal "2012-01-01T00:00:00.000Z" ‑ Date new Date("12.1") .toISOString() does NOT equal "2012-01-01T00:00:00.000Z"
Date new Date("12.1") .toISOString() equals "2001-12-01T00:00:00.000" ‑ Date new Date("12.1") .toISOString() equals "2001-12-01T00:00:00.000"
Date new Date("May 4 UTC") .toISOString() does NOT equal "2010-04-30T23:00:00.000Z" ‑ Date new Date("May 4 UTC") .toISOString() does NOT equal "2010-04-30T23:00:00.000Z"
Date new Date("May 4 UTC") .toISOString() does NOT equal "2010-05-01T00:00:00.000Z" ‑ Date new Date("May 4 UTC") .toISOString() does NOT equal "2010-05-01T00:00:00.000Z"
Date new Date("May 4 UTC") .toISOString() parses UTC as "2001-05-04T00:00:00.000Z" ‑ Date new Date("May 4 UTC") .toISOString() parses UTC as "2001-05-04T00:00:00.000Z"
Date new Date("May 4 UTC+1") .toISOString() does NOT equal "2001-05-04T00:00:00.000Z" ‑ Date new Date("May 4 UTC+1") .toISOString() does NOT equal "2001-05-04T00:00:00.000Z"
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
Date new Date("fourth of may 2010") does NOT equal "2010-05-01T00:00:00.000Z" ‑ Date new Date("fourth of may 2010") does NOT equal "2010-05-01T00:00:00.000Z"
Date new Date("fourth of may 2010") .toISOString() does NOT equal "2010-05-01T00:00:00.000" ‑ Date new Date("fourth of may 2010") .toISOString() does NOT equal "2010-05-01T00:00:00.000"

@percebus percebus marked this pull request as ready for review October 5, 2025 00:33
@percebus percebus merged commit c79711d into main Oct 5, 2025
9 checks passed
@percebus percebus deleted the test/Date/FF branch October 5, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants