Skip to content

try to fix date key equality issue #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuaslate merged 2 commits into from
Jun 27, 2025
Merged

try to fix date key equality issue #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1906f82
try to fix date key equality issue
joshuaslate Jun 27, 2025
8d21699
gofmt
joshuaslate Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions psm/statemachine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"database/sql"
"errors"
"fmt"
"github.com/pentops/j5/j5types/date_j5t"
"time"

"buf.build/go/protovalidate"
Expand Down Expand Up @@ -528,8 +529,16 @@ func assertPresentKeysMatch[K IKeyset](existing, event K) error {
if !ok {
return fmt.Errorf("event key %s is not present in existing keys", key)
}
if existingValue != eventValue {
return status.Errorf(codes.FailedPrecondition, "event key %s value %s does not match existing value %s", key, eventValue, existingValue)

switch v := existingValue.(type) {
case *date_j5t.Date:
if eventValueAsDate, ok := eventValue.(*date_j5t.Date); !ok || !v.Equals(eventValueAsDate) {
return status.Errorf(codes.FailedPrecondition, "event key %s value %s does not match existing value %s", key, eventValue, existingValue)
}
default:
if existingValue != eventValue {
return status.Errorf(codes.FailedPrecondition, "event key %s value %s does not match existing value %s", key, eventValue, existingValue)
}
}
}

Expand Down